Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong selector expression, unable to move parent category #15665

Merged
merged 2 commits into from Sep 27, 2019
Merged

Wrong selector expression, unable to move parent category #15665

merged 2 commits into from Sep 27, 2019

Conversation

PierreRambaud
Copy link
Contributor

@PierreRambaud PierreRambaud commented Sep 24, 2019 •
edited by eternoendless

Questions Answers
Branch? 1.7.6.x
Description? The css expression is currently broken for the defaultTitle.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #15344
How to test? You shouldn't have error on Safari and should be able to move parent category.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from a team as a code owner September 24, 2019 08:34
@prestonBot prestonBot added 1.7.6.x Branch Bug Type: Bug labels Sep 24, 2019
@PierreRambaud PierreRambaud added this to the 1.7.6.2 milestone Sep 24, 2019
matthieu-rolland
matthieu-rolland previously approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@matthieu-rolland matthieu-rolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matthieu-rolland matthieu-rolland added the Waiting for QA Status: action required, waiting for test feedback label Sep 24, 2019
@sarahdib sarahdib added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Sep 25, 2019
@PierreRambaud
Copy link
Contributor Author

Pull request still in queue but everything is ok https://travis-ci.com/PrestaShop/PrestaShop/builds/128877882 🤔

@jolelievre jolelievre closed this Sep 26, 2019
@jolelievre jolelievre reopened this Sep 26, 2019
@jolelievre
Copy link
Contributor

I closed/reopened it to relaunch the build, let's wait for it!

@PierreRambaud PierreRambaud reopened this Sep 26, 2019
@toutantic toutantic merged commit e12776f into PrestaShop:1.7.6.x Sep 27, 2019
@matks matks mentioned this pull request Sep 27, 2019
Closed
@PierreRambaud PierreRambaud deleted the fix/15344 branch September 27, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toutantic toutantic toutantic approved these changes

@Progi1984 Progi1984 Progi1984 approved these changes

@matks matks matks approved these changes

@jolelievre jolelievre jolelievre approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland left review comments

Assignees
No one assigned
Labels
1.7.6.x Branch Bug Type: Bug QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.2
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@PierreRambaud @jolelievre @toutantic @Progi1984 @matthieu-rolland @matks @sarahdib @prestonBot